Add url dispatcher benchmark for resolving root route when exists many plain routes in the subtree #9954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y plain routes in the subtree
asvetlov
added
bot:chronographer:skip
bdraco
approved these changes
Nov 18, 2024
CodSpeed Performance ReportMerging #9954 will not alter performanceComparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9954 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 121 121
Lines 36682 36707 +25
Branches 4378 4381 +3
=======================================
+ Hits 36214 36239 +25
Misses 315 315
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9958 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
…y plain routes in the subtree (#9954) Yet another benchmark. There is a tree: ``` / /api /api/server /api/server/dispatch /api/server/dispatch/123 /api/server/dispatch/123/update ``` The benchmark resolves the root route `/`. If the search starts from checking deep-most resource it cold be suboptimal. (cherry picked from commit be31bed)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9959 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
…y plain routes in the subtree (#9954) Yet another benchmark. There is a tree: ``` / /api /api/server /api/server/dispatch /api/server/dispatch/123 /api/server/dispatch/123/update ``` The benchmark resolves the root route `/`. If the search starts from checking deep-most resource it cold be suboptimal. (cherry picked from commit be31bed)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #9960 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
…y plain routes in the subtree (#9954) Yet another benchmark. There is a tree: ``` / /api /api/server /api/server/dispatch /api/server/dispatch/123 /api/server/dispatch/123/update ``` The benchmark resolves the root route `/`. If the search starts from checking deep-most resource it cold be suboptimal. (cherry picked from commit be31bed)
asvetlov
added a commit
that referenced
this pull request
Nov 18, 2024
…esolving root route when exists many plain routes in the subtree (#9958) **This is a backport of PR #9954 as merged into master (be31bed).** Yet another benchmark. There is a tree: ``` / /api /api/server /api/server/dispatch /api/server/dispatch/123 /api/server/dispatch/123/update ``` The benchmark resolves the root route `/`. If the search starts from checking deep-most resource it cold be suboptimal. Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Nov 18, 2024
…esolving root route when exists many plain routes in the subtree (#9959) **This is a backport of PR #9954 as merged into master (be31bed).** Yet another benchmark. There is a tree: ``` / /api /api/server /api/server/dispatch /api/server/dispatch/123 /api/server/dispatch/123/update ``` The benchmark resolves the root route `/`. If the search starts from checking deep-most resource it cold be suboptimal. Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Nov 18, 2024
…esolving root route when exists many plain routes in the subtree (#9960) **This is a backport of PR #9954 as merged into master (be31bed).** Yet another benchmark. There is a tree: ``` / /api /api/server /api/server/dispatch /api/server/dispatch/123 /api/server/dispatch/123/update ``` The benchmark resolves the root route `/`. If the search starts from checking deep-most resource it cold be suboptimal. Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another benchmark.
There is a tree:
The benchmark resolves the root route
/. If the search starts from checking deep-most resource it cold be suboptimal.