-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for routing sub_applications #9935
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9935 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 120 120
Lines 36570 36588 +18
Branches 4361 4366 +5
=======================================
+ Hits 36102 36120 +18
Misses 315 315
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9935 will not alter performanceComparing Summary
Benchmarks breakdown
|
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9936 🤖 @patchback |
Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now): 1. sub_apps are placed under non-overlapped top-level single-segment prefixed. `test_resolve_gitapi_subapps` benchmark test this case already. 2. sub_apps shares the same prefix segments, e.g. `/api/manager/plugin/{name}`. This PR covers the second case. (cherry picked from commit 0c31249)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9937 🤖 @patchback |
Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now): 1. sub_apps are placed under non-overlapped top-level single-segment prefixed. `test_resolve_gitapi_subapps` benchmark test this case already. 2. sub_apps shares the same prefix segments, e.g. `/api/manager/plugin/{name}`. This PR covers the second case. (cherry picked from commit 0c31249)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #9938 🤖 @patchback |
Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now): 1. sub_apps are placed under non-overlapped top-level single-segment prefixed. `test_resolve_gitapi_subapps` benchmark test this case already. 2. sub_apps shares the same prefix segments, e.g. `/api/manager/plugin/{name}`. This PR covers the second case. (cherry picked from commit 0c31249)
…ications (#9936) **This is a backport of PR #9935 as merged into master (0c31249).** Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now): 1. sub_apps are placed under non-overlapped top-level single-segment prefixed. `test_resolve_gitapi_subapps` benchmark test this case already. 2. sub_apps shares the same prefix segments, e.g. `/api/manager/plugin/{name}`. This PR covers the second case. Co-authored-by: Andrew Svetlov <[email protected]>
…ications (#9937) **This is a backport of PR #9935 as merged into master (0c31249).** Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now): 1. sub_apps are placed under non-overlapped top-level single-segment prefixed. `test_resolve_gitapi_subapps` benchmark test this case already. 2. sub_apps shares the same prefix segments, e.g. `/api/manager/plugin/{name}`. This PR covers the second case. Co-authored-by: Andrew Svetlov <[email protected]>
…ications (#9938) **This is a backport of PR #9935 as merged into master (0c31249).** Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now): 1. sub_apps are placed under non-overlapped top-level single-segment prefixed. `test_resolve_gitapi_subapps` benchmark test this case already. 2. sub_apps shares the same prefix segments, e.g. `/api/manager/plugin/{name}`. This PR covers the second case. Co-authored-by: Andrew Svetlov <[email protected]>
Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now):
test_resolve_gitapi_subapps
benchmark test this case already./api/manager/plugin/{name}
.This PR covers the second case.