Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9910/4a9bbf92 backport][3.10] Add benchmarks for the URL dispatcher #9915

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 15, 2024

This is a backport of PR #9910 as merged into master (4a9bbf9).

For checking #9907 impact

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #9915 will not alter performance

Comparing patchback/backports/3.10/4a9bbf9237c21ddecf600ce77703dc51c736507a/pr-9910 (89785fa) with 3.10 (d4acbd6)

Summary

✅ 26 untouched benchmarks

🆕 6 new benchmarks

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/4a9bbf9237c21ddecf600ce77703dc51c736507a/pr-9910 Change
🆕 test_resolve_dynamic_resource_url_with_many_routes[pyloop] N/A 4.2 ms N/A
🆕 test_resolve_multiple_fixed_url_with_many_routes[pyloop] N/A 2.8 ms N/A
🆕 test_resolve_multiple_level_fixed_url_with_many_routes[pyloop] N/A 11.1 ms N/A
🆕 test_resolve_root_route[pyloop] N/A 1.1 ms N/A
🆕 test_resolve_single_fixed_url_with_many_routes[pyloop] N/A 1.1 ms N/A
🆕 test_resolve_static_root_route[pyloop] N/A 1.2 ms N/A

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (d4acbd6) to head (89785fa).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9915   +/-   ##
=======================================
  Coverage   97.92%   97.93%           
=======================================
  Files         114      115    +1     
  Lines       35911    35998   +87     
  Branches     4327     4347   +20     
=======================================
+ Hits        35166    35253   +87     
  Misses        553      553           
  Partials      192      192           
Flag Coverage Δ
CI-GHA 97.82% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.52% <100.00%> (+0.01%) ⬆️
OS-Windows 95.14% <100.00%> (+0.01%) ⬆️
OS-macOS 97.22% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.08% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.07% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.59% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.57% <100.00%> (-0.01%) ⬇️
Py-3.8.10 94.53% <100.00%> (+0.01%) ⬆️
Py-3.8.18 96.82% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.99% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.94% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.53% <100.00%> (+<0.01%) ⬆️
VM-macos 97.22% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.52% <100.00%> (+0.01%) ⬆️
VM-windows 95.14% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 08d0a3f into 3.10 Nov 15, 2024
39 of 40 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/4a9bbf9237c21ddecf600ce77703dc51c736507a/pr-9910 branch November 15, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant