Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9852/249855a backport][3.10] Fix system routes polluting the middleware cache #9855

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 13, 2024

(cherry picked from commit 249855a)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 13, 2024
@bdraco bdraco changed the title Fix system routes polluting the middleware cache (#9852) [PR #9852/249855a backport][3.10] Fix system routes polluting the middleware cache Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #9855 will not alter performance

Comparing patchback/backports/3.10/249855ad9cdbdb3d6eca90a0a5b675c409274ab6/pr-9852 (0402179) with 3.10 (e5917cd)

Summary

✅ 24 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review November 13, 2024 14:38
@bdraco bdraco enabled auto-merge (squash) November 13, 2024 14:38
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (158bf30) to head (0402179).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9855   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files         113      113           
  Lines       35837    35853   +16     
  Branches     4316     4317    +1     
=======================================
+ Hits        35092    35108   +16     
  Misses        553      553           
  Partials      192      192           
Flag Coverage Δ
CI-GHA 97.81% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.51% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.12% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.21% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.06% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.05% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.13% <100.00%> (+0.04%) ⬆️
Py-3.11.9 97.15% <100.00%> (-0.01%) ⬇️
Py-3.12.7 97.58% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.57% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.51% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.98% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.97% <100.00%> (+0.04%) ⬆️
Py-pypy7.3.16 96.53% <100.00%> (+<0.01%) ⬆️
VM-macos 97.21% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.51% <100.00%> (+<0.01%) ⬆️
VM-windows 95.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit bc15db6 into 3.10 Nov 13, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/249855ad9cdbdb3d6eca90a0a5b675c409274ab6/pr-9852 branch November 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant