-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid tracking connections per host when there is no limit per host #9756
Conversation
The BaseConnector always tracked connections per hosts even when the limit per host was disabled.
CodSpeed Performance ReportMerging #9756 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9756 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 117 117
Lines 35893 35896 +3
Branches 4260 4263 +3
=======================================
+ Hits 35417 35420 +3
Misses 320 320
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 44d809f on top of patchback/backports/3.11/44d809f330aa249de582d8c3cdfd284fb4247483/pr-9756 Backporting merged PR #9756 into master
🤖 @patchback |
… when there is no limit per host (#9758)
The BaseConnector always tracked connections per hosts even when the limit per host was disabled. All the book-keeping has overhead that we can avoid since in most cases there is no limit per host and no need to track connections per host.
BaseConnector._available_connections()
was smart enough to skip checking the current connections iflimit_per_hosts
was not set, but the other areas still did all the book keeping even though it was ignored.