Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] Refactor FlowControlDataQueue.read to improve performances #9663

Closed
wants to merge 8 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2024

test backport of #9659

Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #9663 will improve performances by 12.28%

Comparing flow_311 (2d06d71) with 3.11 (8f6d7b5)

Summary

⚡ 3 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

Benchmark 3.11 flow_311 Change
test_one_thousand_round_trip_websocket_binary_messages[pyloop] 20.5 ms 18.3 ms +11.74%
test_one_thousand_round_trip_websocket_text_messages[pyloop] 21 ms 18.8 ms +11.98%
test_read_one_hundred_websocket_text_messages[pyloop] 370.6 µs 330.1 µs +12.28%

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.89%. Comparing base (8f6d7b5) to head (2d06d71).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/streams.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #9663      +/-   ##
==========================================
- Coverage   97.89%   97.89%   -0.01%     
==========================================
  Files         117      117              
  Lines       35550    35564      +14     
  Branches     4261     4264       +3     
==========================================
+ Hits        34802    34815      +13     
- Misses        559      560       +1     
  Partials      189      189              
Flag Coverage Δ
CI-GHA 97.77% <97.87%> (-0.01%) ⬇️
OS-Linux 97.47% <97.87%> (+<0.01%) ⬆️
OS-Windows 94.37% <97.87%> (-0.01%) ⬇️
OS-macOS 96.67% <97.87%> (-0.01%) ⬇️
Py-3.10.11 96.54% <97.87%> (+<0.01%) ⬆️
Py-3.10.15 96.97% <97.87%> (-0.01%) ⬇️
Py-3.11.10 97.04% <97.87%> (-0.01%) ⬇️
Py-3.11.9 96.62% <97.87%> (+<0.01%) ⬆️
Py-3.12.7 97.51% <97.87%> (-0.01%) ⬇️
Py-3.13.0 97.49% <97.87%> (-0.01%) ⬇️
Py-3.9.13 96.46% <97.87%> (-0.01%) ⬇️
Py-3.9.20 96.89% <97.87%> (-0.01%) ⬇️
Py-pypy7.3.16 96.49% <97.87%> (-0.01%) ⬇️
VM-macos 96.67% <97.87%> (-0.01%) ⬇️
VM-ubuntu 97.47% <97.87%> (+<0.01%) ⬆️
VM-windows 94.37% <97.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Nov 4, 2024

too messy, will need to do some missed backports

@bdraco bdraco closed this Nov 4, 2024
@bdraco bdraco deleted the flow_311 branch November 4, 2024 01:38
@bdraco bdraco restored the flow_311 branch November 4, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant