Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow View methods customization #960

Closed
wants to merge 1 commit into from
Closed

Allow View methods customization #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions aiohttp/web_urldispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,9 +652,11 @@ def __repr__(self):

class View(AbstractView):

METHODS = set(hdrs.METH_ALL)

@asyncio.coroutine
def __iter__(self):
if self.request.method not in hdrs.METH_ALL:
if self.request.method not in self.METHODS:
self._raise_allowed_methods()
method = getattr(self, self.request.method.lower(), None)
if method is None:
Expand All @@ -667,7 +669,7 @@ def __await__(self):
return (yield from self.__iter__())

def _raise_allowed_methods(self):
allowed_methods = {m for m in hdrs.METH_ALL if hasattr(self, m)}
allowed_methods = {m for m in self.METHODS if hasattr(self, m)}
raise HTTPMethodNotAllowed(self.request.method, allowed_methods)


Expand Down