-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow URLs with paths that end with /
as base_url in ClientSession
#9530
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9530 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 113 113
Lines 35266 35295 +29
Branches 4188 4193 +5
=======================================
+ Hits 34773 34802 +29
Misses 331 331
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9530 will not alter performanceComparing Summary
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions on docs. Otherwise, I think this is ready to merge.
Co-authored-by: Sam Bull <[email protected]>
Formatting of the client reference block isn't great, but its an existing problem so not something that needs to be fixed here |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply f3a3f60 on top of patchback/backports/3.11/f3a3f60b7a4b181272472b188e67d3b5f4ad3306/pr-9530 Backporting merged PR #9530 into master
🤖 @patchback |
…io-libs#9530) (cherry picked from commit f3a3f60)
… / as base_url in ClientSession (#9583)
What do these changes do?
_build_url
to test url joining when base_url includes path.Are there changes in behavior for the user?
base_url
inClientSession
now accepts URLs without paths or with paths that end with/
Is it a substantial burden for the maintainers to support this?
Related issue number
Fixes #6647
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.