Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9485/da0099dc backport][3.11] Avoid passing client writer to response when already finished #9493

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 16, 2024

This is a backport of PR #9485 as merged into master (da0099d).

What do these changes do?

With Python 3.12+ its likely that the writer can finish synchronously (on a production HA instance, it always did for all samples in a 60s period). In this case avoid passing it to the response since it will get unset right away needlessly

Are there changes in behavior for the user?

no

@bdraco bdraco enabled auto-merge (squash) October 16, 2024 06:03
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@1e5d5bf). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9493   +/-   ##
=======================================
  Coverage        ?   97.85%           
=======================================
  Files           ?      106           
  Lines           ?    35211           
  Branches        ?     4227           
=======================================
  Hits            ?    34455           
  Misses          ?      564           
  Partials        ?      192           
Flag Coverage Δ
CI-GHA 97.73% <100.00%> (?)
OS-Linux 97.42% <100.00%> (?)
OS-Windows 94.85% <100.00%> (?)
OS-macOS 97.12% <100.00%> (?)
Py-3.10.11 96.98% <75.00%> (?)
Py-3.10.15 96.92% <75.00%> (?)
Py-3.11.10 97.00% <75.00%> (?)
Py-3.11.9 97.07% <75.00%> (?)
Py-3.12.7 97.46% <100.00%> (?)
Py-3.13.0 97.45% <100.00%> (?)
Py-3.9.13 96.89% <75.00%> (?)
Py-3.9.20 96.83% <75.00%> (?)
Py-pypy7.3.16 96.44% <75.00%> (?)
VM-macos 97.12% <100.00%> (?)
VM-ubuntu 97.42% <100.00%> (?)
VM-windows 94.85% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 50ad770 into 3.11 Oct 16, 2024
31 of 32 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/da0099dc608384ceda8415219bade8101a63018d/pr-9485 branch October 16, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant