-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small performance improvement to handling redirects #9467
Conversation
Reverse the conditional so the origin is only checked if not is_same_host_https_redirect
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9467 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 105 105
Lines 35089 35089
Branches 4178 4178
=======================================
Hits 34595 34595
Misses 329 329
Partials 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2b13e3b on top of patchback/backports/3.10/2b13e3bd340c831ba44f29fb9a8592806971adff/pr-9467 Backporting merged PR #9467 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2b13e3b on top of patchback/backports/3.11/2b13e3bd340c831ba44f29fb9a8592806971adff/pr-9467 Backporting merged PR #9467 into master
🤖 @patchback |
Looks like this is only in master anyways |
Reverse the conditional so the origin is only checked if not is_same_host_https_redirect