Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9083/a6dd415 backport][3.10] Remove unused backwards compatibility code for old yarl versions #9289

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 24, 2024

(cherry picked from commit a6dd415)

We ended up bumping yarl to 1.12.0+ for path_safe so we can remove these compat shims

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 24, 2024
@bdraco bdraco marked this pull request as ready for review September 24, 2024 20:25
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (a8542a8) to head (e3702f8).
Report is 2 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #9289      +/-   ##
==========================================
- Coverage   97.78%   97.78%   -0.01%     
==========================================
  Files         108      108              
  Lines       34840    34828      -12     
  Branches     4164     4158       -6     
==========================================
- Hits        34070    34058      -12     
  Misses        573      573              
  Partials      197      197              
Flag Coverage Δ
CI-GHA 97.68% <100.00%> (-0.01%) ⬇️
OS-Linux 97.36% <100.00%> (-0.01%) ⬇️
OS-Windows 94.97% <100.00%> (-0.01%) ⬇️
OS-macOS 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.04% <100.00%> (-0.01%) ⬇️
Py-3.10.15 96.98% <100.00%> (-0.01%) ⬇️
Py-3.11.10 96.94% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.02% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.40% <100.00%> (-0.01%) ⬇️
Py-3.13.0-rc.2 97.39% <100.00%> (-0.01%) ⬇️
Py-3.8.10 94.48% <100.00%> (-0.01%) ⬇️
Py-3.8.18 96.77% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.95% <100.00%> (-0.01%) ⬇️
Py-3.9.20 96.89% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.50% <100.00%> (-0.01%) ⬇️
VM-macos 97.06% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.36% <100.00%> (-0.01%) ⬇️
VM-windows 94.97% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title Remove unused backwards compatibility code for old yarl versions (#9083) [PR #9083/a6dd415 backport][3.10] Remove unused backwards compatibility code for old yarl versions Sep 24, 2024
@bdraco bdraco merged commit 0b82655 into 3.10 Sep 24, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/a6dd415a1401c82722aed12b86ab878e9afb017f/pr-9083 branch September 24, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant