[PR #9204/34a626da backport][3.10] Significantly speed up filter_cookies #9243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit 34a626d)
bdraco
approved these changes
Sep 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.10 #9243 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 108 108
Lines 34738 34747 +9
Branches 4148 4150 +2
=======================================
+ Hits 33972 33981 +9
Misses 573 573
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.10/34a626dad03a013766c668a8db59d53c036177dd/pr-9204
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9204 as merged into master (34a626d).
What do these changes do?
Significantly speed up filter_cookies by adding a cache for morsel construction. Previously every request had to create new Morsel objects. Its a common pattern to set a cookie once and read it many times. When testing with Home Assistant, the cache had nearly a 100% hit rate.
Benchmark #7790 (comment)
before
filter_domain: 6.765125583391637
after
filter_domain: 1.3521433752030134
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no