Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging exception from run_app() that is also raised (#8951) #8974

Conversation

Dreamsorcerer
Copy link
Member

(cherry picked from commit 45d6e4f)

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (9503cf7) to head (0664651).
Report is 568 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #8974   +/-   ##
=======================================
  Coverage   97.73%   97.74%           
=======================================
  Files         108      108           
  Lines       34369    34382   +13     
  Branches     4079     4082    +3     
=======================================
+ Hits        33592    33605   +13     
  Misses        581      581           
  Partials      196      196           
Flag Coverage Δ
CI-GHA 97.63% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.32% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.88% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.00% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.02% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.25% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.99% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.93% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.53% <100.00%> (+<0.01%) ⬆️
VM-macos 97.00% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.32% <100.00%> (+<0.01%) ⬆️
VM-windows 94.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Sep 1, 2024
@Dreamsorcerer Dreamsorcerer merged commit 306e42d into 3.11 Sep 1, 2024
30 of 31 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.11/45d6e4f14572bfc4cfc3f32a2c7c72a9cc28f125/pr-8951 branch September 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant