Add clarification about auth parameter in ClientSession #8953
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8953 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 107 107
Lines 34226 34226
Branches 4058 4058
=======================================
Hits 33637 33637
Misses 416 416
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I was thinking about this last night, and maybe one case we should restrict it to an origin would be when base_url is in use. |
Dreamsorcerer
added
backport-3.10
backport-3.11
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8954 🤖 @patchback |
(cherry picked from commit 51ea3b3)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8955 🤖 @patchback |
(cherry picked from commit 51ea3b3)
…eter in ClientSession (#8955) **This is a backport of PR #8953 as merged into master (51ea3b3).** Co-authored-by: Maxim Zemskov <[email protected]>
…eter in ClientSession (#8954) **This is a backport of PR #8953 as merged into master (51ea3b3).** Co-authored-by: Maxim Zemskov <[email protected]>
|
@Dreamsorcerer I think that's a good idea. I'll make a PR either today or tomorrow. |
What do these changes do?
These changes clarify the behavior of the auth parameter in ClientSession.
Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
No.
Related issue number
#6764
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.