Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8875/0478f143 backport][3.10] Fix unclosed transport warning #8906

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Aug 26, 2024

This is a backport of PR #8875 as merged into master (0478f14).

Fixes #5426.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (c19cc77) to head (5b94721).
Report is 212 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8906      +/-   ##
==========================================
+ Coverage   97.64%   97.71%   +0.07%     
==========================================
  Files         108      108              
  Lines       34228    34222       -6     
  Branches     4070     4067       -3     
==========================================
+ Hits        33421    33440      +19     
+ Misses        605      585      -20     
+ Partials      202      197       -5     
Flag Coverage Δ
CI-GHA 97.60% <100.00%> (+0.06%) ⬆️
OS-Linux 97.29% <100.00%> (+0.13%) ⬆️
OS-Windows 94.83% <100.00%> (+0.09%) ⬆️
OS-macOS 96.97% <100.00%> (+0.01%) ⬆️
Py-3.10.11 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.99% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.22% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 94.63% <100.00%> (?)
Py-3.12.5 97.03% <100.00%> (+0.01%) ⬆️
Py-3.8.10 94.47% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.80% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.96% <100.00%> (+0.31%) ⬆️
Py-3.9.19 96.90% <100.00%> (?)
Py-pypy7.3.16 96.49% <100.00%> (?)
VM-macos 96.97% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.29% <100.00%> (+0.13%) ⬆️
VM-windows 94.83% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit ade02bf into 3.10 Aug 26, 2024
33 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/0478f143caba33c7f6b355b8513e3c26d8db7d4d/pr-8875 branch August 26, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant