[PR #8685/e7c02ca4 backport][3.10] Fix exceptions from WebSocket ping task not being consumed #8729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit e7c02ca)
bdraco
approved these changes
Aug 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8729 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 108 108
Lines 34090 34164 +74
Branches 4058 4063 +5
=======================================
+ Hits 33303 33378 +75
Misses 587 587
+ Partials 200 199 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.10/e7c02ca49eac8d9dce197fdcd6273531d0008649/pr-8685
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8685 as merged into master (e7c02ca).
What do these changes do?
Fix exceptions from WebSocket ping task not being consumed
Are there changes in behavior for the user?
No more unexpected un-retrieved exceptions from ping tasks
Is it a substantial burden for the maintainers to support this?
no
Related issue number
related issue home-assistant/core#123653
replaces and closes #7238
fixes #5182
fixes #4153
fixes #2309