Fix url dispatcher index when variable is preceded by a fixed string after a slash #8566
Conversation
|
This was reported to me out of band. An issue report is forthcoming tomorrow. |
|
Will finish this up once I get confirmation from the reporter and an issue report |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8566 +/- ##
=======================================
Coverage 97.68% 97.69%
=======================================
Files 107 107
Lines 33403 33421 +18
Branches 3923 3924 +1
=======================================
+ Hits 32631 32649 +18
Misses 559 559
Partials 213 213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
As indicated can confirm that both test (via gist) and CI for module building (manually patching within respective |
|
Thanks for testing |
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
added
the
backport-3.11
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8578 🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8579 🤖 @patchback |
…able is preceded by a fixed string after a slash (#8578) Co-authored-by: J. Nick Koston <[email protected]> fix for a regression in 3.10.x. Regressed in #7829 fixes #8567
…able is preceded by a fixed string after a slash (#8579) Co-authored-by: J. Nick Koston <[email protected]> fix for a regression in 3.10.x. Regressed in #7829 fixes #8567
What do these changes do?
Fix url dispatcher index when variable is preceded by a fixed string after a slash. We need to strip off the fixed string when creating the index key so we can match against the path at that part of the url.
Are there changes in behavior for the user?
Bugfix for a regression in 3.10.x. Regressed in #7829 fixes #8567
Is it a substantial burden for the maintainers to support this?
no