Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8495/549c95b9 backport][3.10] Shutdown logic: Only wait on handlers #8530

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 22, 2024

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston [email protected]
(cherry picked from commit 549c95b)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston <[email protected]>
(cherry picked from commit 549c95b)
@bdraco bdraco changed the title Shutdown logic: Only wait on handlers (#8495) [PR #8495/549c95b9 backport][3.10] Shutdown logic: Only wait on handlers Jul 22, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.10@be2a8bf). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8530   +/-   ##
=======================================
  Coverage        ?   97.56%           
=======================================
  Files           ?      108           
  Lines           ?    33518           
  Branches        ?     4029           
=======================================
  Hits            ?    32702           
  Misses          ?      594           
  Partials        ?      222           
Flag Coverage Δ
CI-GHA 97.47% <100.00%> (?)
OS-Linux 97.14% <100.00%> (?)
OS-Windows 94.73% <100.00%> (?)
OS-macOS 96.81% <100.00%> (?)
Py-3.10.11 96.92% <100.00%> (?)
Py-3.10.14 96.87% <100.00%> (?)
Py-3.11.9 97.10% <100.00%> (?)
Py-3.12.4 97.22% <100.00%> (?)
Py-3.8.10 94.47% <100.00%> (?)
Py-3.8.18 96.76% <100.00%> (?)
Py-3.9.13 96.91% <100.00%> (?)
Py-3.9.19 96.88% <100.00%> (?)
Py-pypy7.3.16 96.44% <100.00%> (?)
VM-macos 96.81% <100.00%> (?)
VM-ubuntu 97.14% <100.00%> (?)
VM-windows 94.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review July 22, 2024 15:44
@bdraco bdraco requested a review from asvetlov as a code owner July 22, 2024 15:44
@bdraco bdraco merged commit 6f17a67 into 3.10 Jul 22, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/549c95b948dcddd6588f95545ad6c856f693c503/pr-8495 branch July 22, 2024 15:44
@bdraco bdraco mentioned this pull request Jul 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants