Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8498/7bf6ee1 backport][3.10] Avoid creating a future on every websocket receive #8503

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 14, 2024

Co-authored-by: Sam Bull [email protected]
(cherry picked from commit 7bf6ee1)

Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 7bf6ee1)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 14, 2024
@bdraco bdraco changed the title Avoid creating a future on every websocket receive (#8498) [PR #8498/7bf6ee1 backport][3.10] Avoid creating a future on every websocket receive (#8498) Jul 14, 2024
@bdraco bdraco changed the title [PR #8498/7bf6ee1 backport][3.10] Avoid creating a future on every websocket receive (#8498) [PR #8498/7bf6ee1 backport][3.10] Avoid creating a future on every websocket receive Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (1bb5b5f) to head (7222f16).
Report is 217 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8503   +/-   ##
=======================================
  Coverage   97.48%   97.49%           
=======================================
  Files         108      108           
  Lines       33318    33374   +56     
  Branches     4001     4004    +3     
=======================================
+ Hits        32481    32537   +56     
  Misses        611      611           
  Partials      226      226           
Flag Coverage Δ
CI-GHA 97.40% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.07% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.71% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.74% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.84% <100.00%> (-0.01%) ⬇️
Py-3.10.14 96.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.04% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.44% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.84% <100.00%> (+0.01%) ⬆️
Py-3.9.19 96.81% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.38% <100.00%> (+<0.01%) ⬆️
VM-macos 96.74% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.07% <100.00%> (+<0.01%) ⬆️
VM-windows 94.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review July 14, 2024 17:31
@bdraco bdraco requested review from webknjaz and asvetlov as code owners July 14, 2024 17:31
@bdraco bdraco merged commit 3bc89fe into 3.10 Jul 14, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/7bf6ee1719e8b98d4aa9c7578ed016123ee888d9/pr-8498 branch July 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant