Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 3.10: Add tests, accidentally dropped before (#8088) #8141

Conversation

pajod
Copy link
Contributor

@pajod pajod commented Feb 7, 2024

Cherry picked from commit 0016004

Blindly following a machines orders. Unfamiliar with the procedure but assuming removing the newline and annotations is everything the bot wanted.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36b6c53) 97.31% compared to head (474ebcb) 97.41%.
Report is 3 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8141      +/-   ##
==========================================
+ Coverage   97.31%   97.41%   +0.09%     
==========================================
  Files         108      108              
  Lines       32937    32950      +13     
  Branches     3927     3933       +6     
==========================================
+ Hits        32054    32097      +43     
+ Misses        674      649      -25     
+ Partials      209      204       -5     
Flag Coverage Δ
CI-GHA 97.32% <100.00%> (+0.09%) ⬆️
OS-Linux 97.01% <100.00%> (+0.09%) ⬆️
OS-Windows 94.55% <100.00%> (+0.09%) ⬆️
OS-macOS 96.83% <100.00%> (+0.09%) ⬆️
Py-3.10.11 94.45% <100.00%> (+0.09%) ⬆️
Py-3.10.13 96.79% <100.00%> (+0.08%) ⬆️
Py-3.11.7 96.44% <69.56%> (+0.06%) ⬆️
Py-3.12.1 96.44% <69.56%> (+0.06%) ⬆️
Py-3.8.10 94.43% <100.00%> (+0.09%) ⬆️
Py-3.8.18 96.73% <100.00%> (+0.09%) ⬆️
Py-3.9.13 94.44% <100.00%> (+0.09%) ⬆️
Py-3.9.18 96.78% <100.00%> (+0.09%) ⬆️
Py-pypy7.3.15 96.30% <69.56%> (+0.06%) ⬆️
VM-macos 96.83% <100.00%> (+0.09%) ⬆️
VM-ubuntu 97.01% <100.00%> (+0.09%) ⬆️
VM-windows 94.55% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 0467c9b into aio-libs:3.10 Feb 8, 2024
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants