Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate cookie expiration calls in the CookieJar implementation (#7784) #8047

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 21, 2024

Co-authored-by: Sam Bull [email protected]
(cherry picked from commit e8339e7)

@bdraco bdraco requested a review from asvetlov as a code owner January 21, 2024 02:07
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 21, 2024
@bdraco bdraco changed the title Fix duplicate cookie expiration calls in the CookieJar implementation… Fix duplicate cookie expiration calls in the CookieJar implementation (#7784) Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a42ed20) 97.32% compared to head (c47dfc3) 97.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8047      +/-   ##
==========================================
+ Coverage   97.32%   97.39%   +0.06%     
==========================================
  Files         108      108              
  Lines       32799    32810      +11     
  Branches     3903     3904       +1     
==========================================
+ Hits        31922    31955      +33     
+ Misses        668      650      -18     
+ Partials      209      205       -4     
Flag Coverage Δ
CI-GHA 97.30% <100.00%> (+0.05%) ⬆️
OS-Linux 96.99% <100.00%> (+0.06%) ⬆️
OS-Windows 94.52% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.81% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 94.42% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.78% <100.00%> (?)
Py-3.11.7 96.48% <100.00%> (+<0.01%) ⬆️
Py-3.12.1 96.44% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.40% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.71% <100.00%> (?)
Py-3.9.13 94.40% <100.00%> (-0.01%) ⬇️
Py-3.9.18 96.75% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.15 96.30% <100.00%> (?)
VM-macos 96.81% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.99% <100.00%> (+0.06%) ⬆️
VM-windows 94.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 1a389a5 into 3.10 Jan 21, 2024
28 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/e8339e7687a6c228076f788237b6dbe95ae711e5/pr-7784 branch January 21, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant