Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message is not upgraded if Upgrade header is missing (#7895) #7898

Conversation

Dreamsorcerer
Copy link
Member

(cherry picked from commit fde031f)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 25, 2023
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) November 25, 2023 19:48
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb11101) 97.34% compared to head (0dfc0b2) 97.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##              3.9    #7898   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         108      108           
  Lines       32433    32439    +6     
  Branches     3848     3848           
=======================================
+ Hits        31573    31579    +6     
  Misses        655      655           
  Partials      205      205           
Flag Coverage Δ
CI-GHA 97.25% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.95% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.44% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 94.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.73% <100.00%> (+<0.01%) ⬆️
Py-3.11.6 96.45% <100.00%> (+<0.01%) ⬆️
Py-3.12.0 96.50% <100.00%> (?)
Py-3.8.10 94.32% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.65% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.33% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.70% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.13 96.16% <100.00%> (+<0.01%) ⬆️
VM-macos 96.56% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.95% <100.00%> (+<0.01%) ⬆️
VM-windows 94.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 2ae4d6f into 3.9 Nov 25, 2023
25 of 29 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/fde031fe7b0d6060eab4ff13d588a882bb7a1ddb/pr-7895 branch November 25, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant