[PR #7283/0e7c272f backport][3.9] Add note about updating headers in on_response_prepare #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## 3.9 #7294 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 107 107
Lines 31649 31649
Branches 4027 4027
=======================================
Hits 30800 30800
Misses 643 643
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dreamsorcerer
deleted the
patchback/backports/3.9/0e7c272f8b7e7c610819ee362aeae234c308449c/pr-7283
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7283 as merged into master (0e7c272).
Fixes #6443.
It seems like it'll be easier just to document this. Only solution that looks like it'd work is to update the Content-Length header every time the body is changed, but that could incur a performance penalty for little reason.