Cover ttl=0 (expire always) _DNSCacheTable case (#7014) #7045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for your contribution! -->
Fix bug when using ttl_dns_cache=0
<!-- Please give a short brief about these changes. -->
When using `ttl_dns_cache=0`, hostname is added to cache and on expire
check there is a KeyError as it is never added into _timestamp
dictionary.
Added a short description to docs ClientSession advising to use
`use_dns_cache` instead of `ttl_dns_cache=0` for always expiring cache.
Alternative to this change is to enforce user to use positive none 0
float or None for `ttl_dns_cache` during init time and in case of using
0 implicitly change `use_dns_cache` to False or raise exception.
No.
<!-- Outline any notable behaviour for the end users. -->
<!-- Are there any issues opened that will be resolved by merging this
change? -->
- [X] I think the code is well written
- [X] Unit tests for the changes exist
- [X] Documentation reflects the changes
- [X] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
* The format is <Name> <Surname>.
* Please keep alphabetical order, the file is sorted by names.
- [X] Add a new news fragment into the `CHANGES` folder
* name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
* ensure type is one of the following:
* `.feature`: Signifying a new feature.
* `.bugfix`: Signifying a bug fix.
* `.doc`: Signifying a documentation improvement.
* `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."
Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 12f56d7)
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Backport from #7014 |
Codecov Report
@@ Coverage Diff @@
## 3.9 #7045 +/- ##
==========================================
+ Coverage 97.25% 97.31% +0.05%
==========================================
Files 103 103
Lines 30183 30198 +15
Branches 3738 3745 +7
==========================================
+ Hits 29354 29386 +32
+ Misses 633 617 -16
+ Partials 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug when using ttl_dns_cache=0
When using `ttl_dns_cache=0`, hostname is added to cache and on expire check there is a KeyError as it is never added into _timestamp dictionary.Added a short description to docs ClientSession advising to use
use_dns_cacheinstead ofttl_dns_cache=0for always expiring cache.Alternative to this change is to enforce user to use positive none 0 float or None for
ttl_dns_cacheduring init time and in case of using 0 implicitly changeuse_dns_cacheto False or raise exception. No.CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature. *.bugfix: Signifying a bug fix. *.doc: Signifying a documentation improvement. *.removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Co-authored-by: Sam Bull [email protected]
(cherry picked from commit 12f56d7)
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.