Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6843/f90cb195 backport][3.9] Add type Path on web app run #6957

Conversation

webknjaz
Copy link
Member

This is a backport of PR #6843 as merged into master (f90cb19).

(cherry picked from commit f90cb19)

What do these changes do?

I modify the web.py file and add Union[str,pathlib.Path] for path

Are there changes in behavior for the user?

For the option of path, we can have str or pathlib.path

Related issue number

#6839

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz requested a review from asvetlov as a code owner September 22, 2022 00:18
@webknjaz webknjaz self-assigned this Sep 22, 2022
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 22, 2022
@webknjaz webknjaz changed the title Add Path support on web app run (#6843) [PR #6843/f90cb195 backport][3.9] Add type Path on web app run Sep 22, 2022
@webknjaz webknjaz enabled auto-merge (squash) September 22, 2022 00:19
@webknjaz webknjaz mentioned this pull request Sep 22, 2022
5 tasks
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #6957 (95305f9) into 3.9 (973fe93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              3.9    #6957   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         107      107           
  Lines       31197    31199    +2     
  Branches     3953     3953           
=======================================
+ Hits        30314    30316    +2     
  Misses        669      669           
  Partials      214      214           
Flag Coverage Δ
CI-GHA 97.06% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.73% <100.00%> (-0.01%) ⬇️
OS-Windows 94.36% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.6 96.44% <100.00%> (+<0.01%) ⬆️
Py-3.10.7 96.54% <100.00%> (-0.01%) ⬇️
Py-3.11.0-rc.2 96.22% <100.00%> (-0.05%) ⬇️
Py-3.7.13 96.54% <100.00%> (+<0.01%) ⬆️
Py-3.7.9 94.21% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.13% <100.00%> (+<0.01%) ⬆️
Py-3.8.13 96.48% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.74% <100.00%> (-0.03%) ⬇️
Py-3.9.14 96.23% <100.00%> (-0.12%) ⬇️
Py-pypy7.3.9 96.07% <100.00%> (-0.01%) ⬇️
VM-macos 96.35% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.73% <100.00%> (-0.01%) ⬇️
VM-windows 94.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web.py 99.15% <100.00%> (+<0.01%) ⬆️
aiohttp/web_runner.py 97.61% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz merged commit e9e3a62 into aio-libs:3.9 Sep 22, 2022
@webknjaz webknjaz deleted the patchback/backports/3.9/f90cb1952c272936845b93a8f424b32e703d545c/pr-6843 branch April 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants