Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the object possibility from the ClientSession.timeout type #6923

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Exclude the object possibility from the ClientSession.timeout type #6923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5411937
Fix ClientSession.timeout typing
DevilXD Sep 20, 2022
31905a4
Add a news fragment
DevilXD Sep 20, 2022
229b73d
Update the change note to reflect the type change
webknjaz Sep 20, 2022
3be3fb9
Switch the change note type to "bugfix"
webknjaz Sep 20, 2022
fee3de1
Alias the change not to the "doc" category too
webknjaz Sep 20, 2022
9b77aa4
Link the change notes to PR #6923
webknjaz Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES/6917.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Dropped the :class:`object` type possibility from
the :py:attr:`aiohttp.ClientSession.timeout`
property return type declaration.
1 change: 1 addition & 0 deletions CHANGES/6917.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
6917.bugfix
1 change: 1 addition & 0 deletions CHANGES/6923.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
6917.bugfix
1 change: 1 addition & 0 deletions CHANGES/6923.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
6917.doc
2 changes: 1 addition & 1 deletion aiohttp/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ def requote_redirect_url(self) -> bool:
return self._requote_redirect_url

@property
def timeout(self) -> Union[object, ClientTimeout]:
def timeout(self) -> ClientTimeout:
"""Timeout for the session."""
return self._timeout

Expand Down