Allow filename content disposition to have space in accordance with RFC6266 Appendix D

[ben-cutler-datarobot]

What do these changes do?

According to RFC 6266 Appendix D:
https://datatracker.ietf.org/doc/html/rfc6266#appendix-D

   o  Avoid including the percent character followed by two hexadecimal
      characters (e.g., %A9) in the filename parameter, since some
      existing implementations consider it to be an escape character,
      while others will pass it through unchanged.

The current implementation of aiohttp does encode spaces of the filename, and this implementation should be avoided,.

Are there changes in behavior for the user?

Yes, filenames will no longer be encoded.

This is not exactly a new change for users on aiohttp 3.7 though. The filename was not encoded until this Pr #4012 encoded it.

Related issue number

Checklist

• [✅] I think the code is well written
• [✅] Unit tests for the changes exist
• [⚠️] Documentation reflects the changes
• [✅] If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• [✅] Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[ben-cutler-datarobot]

I realized there's a better solution. I realized the FormData has a constructor param (quote_fields=False) that I should be using instead

[madduck]

I realized there's a better solution. I realized the FormData has a constructor param (quote_fields=False) that I should be using instead

Doesn't this potentially have side-effects we don't want? After all, fields should be quoted in general, no? Just the filename should not be quoted…