Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6205/f8b07dd6 backport][3.9] Set the minimum required setuptools to v46.4.0 #6226

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 2, 2021

This is a backport of PR #6205 as merged into master (f8b07dd).

In order to avoid a recursive dependency issue when parsing the aiohttp version during install setuptools needs:
pypa/setuptools@c457e68

This implies we need setuptools 46.4.0 or newer.

This should probably also be back-ported as this setuptools version requirement was introduced in 3.8.

What do these changes do?

Adds setuptools >= 46.4.0 requirement to pyproject.toml and readme.

Are there changes in behavior for the user?

Should ensure setuptools version is correct instead of cryptic build dependency errors.

Related issue number

N/A

Checklist

  • [N/A] I think the code is well written
  • [N/A] Unit tests for the changes exist
  • Documentation reflects the changes
  • [N/A] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit f8b07dd)
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (3.9@31ebc5e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f8b07dd differs from pull request most recent head 276db9b. Consider uploading reports for the commit 276db9b to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##             3.9    #6226   +/-   ##
======================================
  Coverage       ?   93.30%           
======================================
  Files          ?      103           
  Lines          ?    30360           
  Branches       ?     2729           
======================================
  Hits           ?    28326           
  Misses         ?     1857           
  Partials       ?      177           
Flag Coverage Δ
unit 93.22% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ebc5e...276db9b. Read the comment docs.

@webknjaz webknjaz merged commit 5dd51a8 into 3.9 Nov 2, 2021
@webknjaz webknjaz deleted the patchback/backports/3.9/f8b07dd62facc4c004b349d6e16b790f4b7205c2/pr-6205 branch November 2, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants