Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6165/850785c3 backport][3.8] Migrate packaging toward declarative setup.cfg #6168

Conversation

webknjaz
Copy link
Member

This is a backport of PR #6165 as merged into master (850785c).

(cherry picked from commit 850785c)

What do these changes do?

This patch revamps our packaging setup to follow modern practices more closely.

Are there changes in behavior for the user?

No.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz requested a review from asvetlov as a code owner October 28, 2021 21:39
@webknjaz webknjaz enabled auto-merge (squash) October 28, 2021 21:39
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 28, 2021

This pull request fixes 1 alert when merging b280082 into 8a944a7 - view on LGTM.com

fixed alerts:

  • 1 for `__eq__` not overridden when adding attributes

@webknjaz webknjaz added the bot:chronographer:skip This PR does not need to include a change note label Oct 28, 2021
@webknjaz webknjaz merged commit 4e39c6b into 3.8 Oct 28, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/850785c37ba69b3b6cfa7270d21224c95f86c487/pr-6165 branch October 28, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant