[backport 3.8] Add socket factory to BaseTestServer (#5845) #6152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
derlih
force-pushed
the
patchback/backports/3.8/573916f0ebea517bdb6b162bcf74078acb0dfaf9/pr-5845
branch
from
3b4bce9
to
12d2677
Compare
* Add socket factory to BaseTestServer * Fix the change note style Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit 573916f)
derlih
force-pushed
the
patchback/backports/3.8/573916f0ebea517bdb6b162bcf74078acb0dfaf9/pr-5845
branch
from
12d2677
to
39b2cea
Compare
asvetlov
approved these changes
Oct 28, 2021
derlih
deleted the
patchback/backports/3.8/573916f0ebea517bdb6b162bcf74078acb0dfaf9/pr-5845
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add socket factory to BaseTestServer
Fix the change note style
Co-authored-by: Sviatoslav Sydorenko [email protected]
(cherry picked from commit 573916f)
What do these changes do?
Add a socket factory to BaseTestServer. It enables using custom sockets in tests.
Are there changes in behavior for the user?
No
Related issue number
#5844
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.