-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further optimize the logo/icon #5914
Conversation
It's not exactly required, but projects such as simple-icons use a 24 24 viewbox, and dont move the viewbox into the middle for no reason (instead starting at 0 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 5fab03a on top of patchback/backports/3.8/5fab03a523010c0fb531c064f300e6cfe0d5b67b/pr-5914 Backporting merged PR #5914 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
* Further optimized, now using viewbox of 0 0 24 24 It's not exactly required, but projects such as simple-icons use a 24 24 viewbox, and dont move the viewbox into the middle for no reason (instead starting at 0 0) * Added color to the icon * Update aiohttp-plain.svg * Added same height width as original * Update aiohttp-plain.svg * Create 5914.misc * Make the change note clearer Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit 5fab03a)
* Further optimized, now using viewbox of 0 0 24 24 It's not exactly required, but projects such as simple-icons use a 24 24 viewbox, and dont move the viewbox into the middle for no reason (instead starting at 0 0) * Added color to the icon * Update aiohttp-plain.svg * Added same height width as original * Update aiohttp-plain.svg * Create 5914.misc * Make the change note clearer Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit 5fab03a) Co-authored-by: Shady Goat <[email protected]>
What do these changes do?
The only thing this does is make further optimizations to the svg of the icon. It also changes the viewbox from 76 to 24, so that it can be used easier for projects that use tools like simple-icons
Are there changes in behavior for the user?
Not really, unless the extract the raw path data. It still has the same height & width, so should not affect users.
Related issue number
None
Checklist
Irrelevant:
CONTRIBUTORS.txt
Relevant:
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.