Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all sphinx-build invocations are strict #5778

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Jun 7, 2021

What do these changes do?

This is a follow-up for #5776 covering missing places w/o the strictness enforced.

Are there changes in behavior for the user?

No.

Related issue number

#5518

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz added enhancement documentation Improvements or additions to documentation backport-3.8 labels Jun 7, 2021
@webknjaz webknjaz requested a review from asvetlov as a code owner June 7, 2021 11:33
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #5778 (3b18e84) into master (9c084ae) will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5778      +/-   ##
==========================================
+ Coverage   96.83%   97.17%   +0.34%     
==========================================
  Files          41       41              
  Lines        8865     8865              
  Branches     1425     1425              
==========================================
+ Hits         8584     8615      +31     
+ Misses        162      133      -29     
+ Partials      119      117       -2     
Flag Coverage Δ
unit 97.06% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_protocol.py 86.41% <0.00%> (+0.28%) ⬆️
aiohttp/helpers.py 96.83% <0.00%> (+0.42%) ⬆️
aiohttp/http_writer.py 99.12% <0.00%> (+3.50%) ⬆️
aiohttp/http_parser.py 97.46% <0.00%> (+5.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c084ae...3b18e84. Read the comment docs.

@webknjaz webknjaz merged commit b141f8b into master Jun 7, 2021
@webknjaz webknjaz deleted the docs/show-all-warnings-at-once-in-global-makefile branch June 7, 2021 11:56
@patchback
Copy link
Contributor

patchback bot commented Jun 7, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/b141f8b78d5ef1c2a3415aff379dba2eeed99c2f/pr-5778

Backported as #5779

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 7, 2021
webknjaz added a commit that referenced this pull request Jun 7, 2021
… are strict (#5779)

* Ensure all sphinx-build invocations are strict (#5778)

(cherry picked from commit b141f8b)

* Fix the spelling of `ClientSession`

* Fix the ref to aiohttp.test_utils

* Ignore undocumented exceptions in Sphinx

* Mark `testing.rst` as `aiohttp.test_utils` mod

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant