Fix broken references in docs/new_router.rst
#5743
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5743 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 41 41
Lines 8865 8865
Branches 1425 1425
=======================================
Hits 8615 8615
Misses 133 133
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
docs/new_router.rst
Outdated
| @@ -81,4 +81,4 @@ shortcut for:: | |||
| return route | |||
|
|
|||
| ``app.router.register_route(...)`` is still supported, it creates | |||
| :class:`aiohttp.web.ResourceAdapter` for every call (but it's deprecated now). | |||
| :class:`aiohttp.web.StaticResource` for every call (but it's deprecated now). | |||
There was a problem hiding this comment.
This is a historic document pointing at something that doesn't exist anymore. So just remove the class role instead of pointing at a wrong thing.
| :class:`aiohttp.web.StaticResource` for every call (but it's deprecated now). | |
| ``aiohttp.web.ResourceAdapter`` for every call (but it's deprecated now). |
There was a problem hiding this comment.
I decided that ResourceAdaptep was replaced by StaticResource, but okay
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #5768 🤖 @patchback |
(cherry picked from commit e78ea41)
…router.rst` (#5768) (cherry picked from commit e78ea41) Co-authored-by: Olexiy Pohorely <[email protected]>
What do these changes do?
This change corrects multiple unrendered intersphinx class reference in the `new_router.rst` document.Are there changes in behavior for the user?
NoRelated issue number
#5518Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.