Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete pip-tools setup (backport #5486) #5508

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Complete pip-tools setup (backport #5486) #5508

merged 1 commit into from
Mar 14, 2021

Conversation

greshilov
Copy link
Contributor

What do these changes do?

Backport #5486.

Are there changes in behavior for the user?

No.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 28, 2021
@greshilov greshilov changed the title Complete pip-tools setup (#5486) [WIP] Complete pip-tools setup (#5486) Mar 1, 2021
@greshilov greshilov force-pushed the complete-pip-tools-setup branch from bf3df92 to 93f7584 Compare March 1, 2021 01:09
@greshilov greshilov changed the title [WIP] Complete pip-tools setup (#5486) Complete pip-tools setup (backport #5486) Mar 1, 2021
@greshilov greshilov changed the title Complete pip-tools setup (backport #5486) [WIP] Complete pip-tools setup (backport #5486) Mar 1, 2021
@webknjaz webknjaz marked this pull request as draft March 1, 2021 13:05
@webknjaz
Copy link
Member

webknjaz commented Mar 1, 2021

@greshilov when it's WIP, it's best to turn the PR into a draft

@greshilov greshilov force-pushed the complete-pip-tools-setup branch 12 times, most recently from f5ffbc2 to 288b728 Compare March 3, 2021 03:14
@greshilov
Copy link
Contributor Author

@webknjaz PTAL

Unfortunately, I had to consider python version to produce valid requirements. The most interesting commit is 5f0637f.

If the presented approach is OK, we probably need some CI job to pin dependencies on different platforms.

@webknjaz
Copy link
Member

webknjaz commented Mar 6, 2021

I'd like to have a solution that works with dependabot. Can't we have just a few extra files on the top level?

@webknjaz
Copy link
Member

webknjaz commented Mar 6, 2021

Also, this turned into a feature PR. We should first just make it work the same way as on master. And only then, explore remaking things on master.

@webknjaz
Copy link
Member

webknjaz commented Mar 6, 2021

dependabot/feedback#658

greshilov added a commit to greshilov/aiohttp that referenced this pull request Mar 11, 2021
@greshilov
Complete pip-tools setup (aio-libs#5508)
c11a02f
@greshilov greshilov force-pushed the complete-pip-tools-setup branch from 288b728 to c11a02f Compare March 11, 2021 00:20
greshilov added a commit to greshilov/aiohttp that referenced this pull request Mar 11, 2021
@greshilov
Complete pip-tools setup (aio-libs#5508)
f58163e
@greshilov greshilov force-pushed the complete-pip-tools-setup branch from c11a02f to f58163e Compare March 11, 2021 00:23
greshilov added a commit to greshilov/aiohttp that referenced this pull request Mar 11, 2021
@greshilov
Complete pip-tools setup (aio-libs#5508)
0bef9b7
@greshilov greshilov force-pushed the complete-pip-tools-setup branch from f58163e to 0bef9b7 Compare March 11, 2021 00:37
@greshilov greshilov marked this pull request as ready for review March 11, 2021 00:50
@greshilov greshilov changed the title [WIP] Complete pip-tools setup (backport #5486) Complete pip-tools setup (backport #5486) Mar 11, 2021
greshilov added a commit to greshilov/aiohttp that referenced this pull request Mar 11, 2021
@greshilov
Complete pip-tools setup (aio-libs#5508)
b0b376f
@greshilov greshilov force-pushed the complete-pip-tools-setup branch from 0bef9b7 to b0b376f Compare March 11, 2021 00:55
@greshilov greshilov force-pushed the complete-pip-tools-setup branch from b0b376f to 5ee3fa4 Compare March 11, 2021 01:00
@greshilov
Copy link
Contributor Author

I'd like to have a solution that works with dependabot. Can't we have just a few extra files on the top level?

Done.

@greshilov
Copy link
Contributor Author

@webknjaz eventually, differences with the master branch are not huge. The only problem I see is that dependencies have to be pinned using python3.6. Maybe we should include a comment on that somewhere in development docs.

webknjaz
webknjaz reviewed Mar 14, 2021
View reviewed changes
requirements/doc-spelling.in
@@ -0,0 +1,2 @@
-r doc.txt
sphinxcontrib-spelling==7.1.0; platform_system!="Windows" # We only use it in Travis CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol we switched two CI systems after Travis. But nevermind, the comment not vital for this PR.

webknjaz
webknjaz approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the effort you've put into this!

@webknjaz
Copy link
Member

Maybe we should include a comment on that somewhere in development docs.

Do you think this could cause issues with dependabot?

@webknjaz webknjaz merged commit 30f90c5 into aio-libs:3.8 Mar 14, 2021
@greshilov
Copy link
Contributor Author

Maybe we should include a comment on that somewhere in development docs.

Do you think this could cause issues with dependabot?

I don't think so, but we'll see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greshilov @webknjaz