Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5486.misc #5507

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fix 5486.misc #5507

merged 1 commit into from
Mar 11, 2021

Conversation

greshilov
Copy link
Contributor

What do these changes do?

Fixes for #5486

Are there changes in behavior for the user?

No.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@greshilov greshilov changed the title Add hashes to .txt requirements [WIP] Add hashes to .txt requirements Mar 1, 2021
@greshilov
Copy link
Contributor Author

greshilov commented Mar 1, 2021

@webknjaz looks like the only way to add hashes is to create a separate requirement file for each environment.

For example:

linux-py3.7-dev.txt
mac-py3.8-lint.txt
win32-py3.9-dev.txt

It will be necessary to create a python script tools/deps.py to automate installation and pin processes on different platforms.
Seems like a huge change, but it also will solve problem in 3.8 branch.

@greshilov
Copy link
Contributor Author

greshilov commented Mar 1, 2021

Yep, you've already suggested this approach in #5496, #5486.

@webknjaz
Copy link
Member

webknjaz commented Mar 1, 2021

linux-py3.7-dev.txt
mac-py3.8-lint.txt
win32-py3.9-dev.txt

I think that we don't need it per-python but per-OS. If you use the lowest supported Python to generate the constraints, it should be fine.

@webknjaz webknjaz marked this pull request as draft March 1, 2021 13:08
@greshilov greshilov force-pushed the add-requirements-hashes branch from 1774b88 to 1ea7225 Compare March 11, 2021 01:15
@greshilov greshilov changed the title [WIP] Add hashes to .txt requirements Fix 5486.misc Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #5507 (1ea7225) into master (ae8e1b0) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5507      +/-   ##
==========================================
- Coverage   97.17%   97.17%   -0.01%     
==========================================
  Files          41       41              
  Lines        8860     8854       -6     
  Branches     1424     1424              
==========================================
- Hits         8610     8604       -6     
  Misses        133      133              
  Partials      117      117              
Flag Coverage Δ
unit 97.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/test_utils.py 99.68% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8e1b0...1ea7225. Read the comment docs.

@greshilov greshilov marked this pull request as ready for review March 11, 2021 01:22
@webknjaz webknjaz merged commit fbce0ac into aio-libs:master Mar 11, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants