-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 5486.misc #5507
Fix 5486.misc #5507
Conversation
@webknjaz looks like the only way to add hashes is to create a separate requirement file for each environment. For example:
It will be necessary to create a |
I think that we don't need it per-python but per-OS. If you use the lowest supported Python to generate the constraints, it should be fine. |
1774b88
to
1ea7225
Compare
Codecov Report
@@ Coverage Diff @@
## master #5507 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 41 41
Lines 8860 8854 -6
Branches 1424 1424
==========================================
- Hits 8610 8604 -6
Misses 133 133
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What do these changes do?
Fixes for #5486
Are there changes in behavior for the user?
No.
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.