Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore 304/204 response body #549

Merged
merged 2 commits into from
Oct 4, 2015
Merged

Ignore 304/204 response body #549

merged 2 commits into from
Oct 4, 2015

Conversation

carlcarl
Copy link
Contributor

@carlcarl carlcarl commented Oct 3, 2015

Fix #505

@asvetlov
Copy link
Member

asvetlov commented Oct 3, 2015

Please rewrite tests to use test_client_functional_newstyle.py not test_client_functional.py

@carlcarl
Copy link
Contributor Author

carlcarl commented Oct 3, 2015

Oh, didn't notice that.
So all the tests should be moved to test_client_functional_newstyle.py in the future?

@asvetlov
Copy link
Member

asvetlov commented Oct 3, 2015

Yes. I even plan to rewrite these in py.test style but as first step I want to get rid of test_utils server.

@carlcarl
Copy link
Contributor Author

carlcarl commented Oct 3, 2015

Done.

asvetlov added a commit that referenced this pull request Oct 4, 2015
@asvetlov
Merge pull request #549 from carlcarl/ignore_304_response_body
b95b88c 
Ignore 304/204 response body
@asvetlov asvetlov merged commit b95b88c into aio-libs:master Oct 4, 2015
@asvetlov
Copy link
Member

asvetlov commented Oct 4, 2015

Thanks

@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client use aiohttp, will be hang up ,when server return 304
2 participants
@carlcarl @asvetlov