Return hostnames from ThreadedResolver #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
asvetlov
approved these changes
Oct 24, 2020
|
Please fix failed tests, I'm pretty sure that they are related to your change |
|
(sorry, didn't mean to click "comment" yet!) |
|
It looks like c48f2d1, which introduced this bug, also modified the test to assert incorrect behavior. @socketpair can you comment on why this was done? Should resolve return an address as "hostname" for the link-local case? Or was this just a change to the test to make it assert what the function now returns. |
Fix a variable-shadowing bug causing `ThreadedResolver.resolve` to return the resolved IP as the "hostname" in each record, which prevented validation of HTTPS connections. Fixes aio-libs#2110.
|
(the updated version here reverts the test change in c48f2d1) |
Yes, it was. I made it by mistake a few days ago. |
asvetlov
approved these changes
Oct 24, 2020
aio-libs-github-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2020
Fix a variable-shadowing bug causing `ThreadedResolver.resolve` to return the resolved IP as the "hostname" in each record, which prevented validation of HTTPS connections. Fixes #2110.
💚 Backport successfulThe PR was backported to the following branches:
|
aio-libs-github-bot bot
added a commit
that referenced
this pull request
Oct 24, 2020
Backports the following commits to 3.7: - Return hostnames from ThreadedResolver (#5118) Co-authored-by: Dustin J. Mitchell <[email protected]>
21 tasks
djmitche
added a commit
to djmitche/taskcluster
that referenced
this pull request
Oct 25, 2020
aio-libs/aiohttp#5110 means that https URLs don't work. aio-libs/aiohttp#5118 fixes the issue, and will be included in 3.7.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix a variable-shadowing bug causing
ThreadedResolver.resolvetoreturn the resolved IP as the "hostname" in each record, which prevented
validation of HTTPS connections. Fixes #5110.
Are there changes in behavior for the user?
Failed HTTPS connections will work again.
Related issue number
Fixes #5110.
Checklist
CONTRIBUTORS.txt(N/A: no new content)CHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.