Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Protocol from typing_extensions #5111

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Import Protocol from typing_extensions #5111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES/5111.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed a type error with reified properties caused by the
conditional import of `Protocol`.
7 changes: 1 addition & 6 deletions aiohttp/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
import async_timeout
import attr
from multidict import MultiDict, MultiDictProxy
from typing_extensions import final
from typing_extensions import Protocol, final
from yarl import URL

from . import hdrs
Expand All @@ -67,11 +67,6 @@
except ImportError:
from typing_extensions import ContextManager

if PY_38:
from typing import Protocol
else:
from typing_extensions import Protocol # type: ignore


def all_tasks(
loop: Optional[asyncio.AbstractEventLoop] = None,
Expand Down