-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.7] Don't cancel web handler on disconnection (#4080) #4771
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.7 #4771 +/- ##
==========================================
+ Coverage 97.56% 97.94% +0.38%
==========================================
Files 44 44
Lines 8953 8964 +11
Branches 1408 1410 +2
==========================================
+ Hits 8735 8780 +45
+ Misses 110 78 -32
+ Partials 108 106 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 3.7 #4771 +/- ##
==========================================
- Coverage 97.62% 97.27% -0.36%
==========================================
Files 44 44
Lines 9020 9033 +13
Branches 1419 1422 +3
==========================================
- Hits 8806 8787 -19
- Misses 95 124 +29
- Partials 119 122 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks! |
What do these changes do?
Backport #4080 to aiohttp 3.7. I'm not sure whether there's gonna be another 3.6 release or if 3.7 is still planned but this allows to handle connections issues properly so would be good to have.
Are there changes in behavior for the user?
ConnectionResetError
is raised on writing to closing transport instead of a warning.Related issue number
#4080
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.