body_exists for requests without body should be False #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hh-h
commented
Jan 25, 2020
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Added CHANGES file |
|
Please sync with the lastest master to get rid of unittest error |
Codecov Report
@@ Coverage Diff @@
## master #4529 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 43 43
Lines 8907 8907
Branches 1403 1403
=======================================
Hits 8693 8693
Misses 95 95
Partials 119 119Continue to review full report at Codecov.
|
|
Done, green 💚 |
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Jan 26, 2020
(cherry picked from commit 72176b2) Co-authored-by: hh-h <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Jan 27, 2020
…4533) (cherry picked from commit 72176b2) Co-authored-by: hh-h <[email protected]> Co-authored-by: hh-h <[email protected]>
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR tries to implement this logic for
_http_parserAre there changes in behavior for the user?
No
Related issue number
#4528
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.