Use loop.sendfile() instead of custom implementation if available #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4517 +/- ##
==========================================
- Coverage 97.6% 97.59% -0.01%
==========================================
Files 43 43
Lines 8899 8907 +8
Branches 1402 1403 +1
==========================================
+ Hits 8686 8693 +7
- Misses 94 95 +1
Partials 119 119
Continue to review full report at Codecov.
|
asvetlov
added a commit
that referenced
this pull request
Jan 19, 2020
…le (#4517) (cherry picked from commit e6f04ce) Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Jan 19, 2020
…le (#4517) (#4518) (cherry picked from commit e6f04ce) Co-authored-by: Andrew Svetlov <[email protected]>
webknjaz
reviewed
Jan 19, 2020
| @@ -94,12 +95,25 @@ def _done_fut(self, out_fd: int, fut: 'asyncio.Future[None]') -> None: | |||
|
|
|||
| async def sendfile(self) -> None: | |||
| assert self.transport is not None | |||
| loop = self.loop | |||
| data = b''.join(self._sendfile_buffer) | |||
There was a problem hiding this comment.
Would the use of memoryview() be faster in this case?
There was a problem hiding this comment.
I doubt that the speed difference is visible at all.
You can measure it if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4269