Test and fix for multidicts' .items(), .keys() and .values() repr #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -305,6 +305,9 @@ def __init__(self, items): | |||
| def __len__(self): | |||
| return len(self._items) | |||
|
|
|||
| def __repr__(self): | |||
There was a problem hiding this comment.
I guess _multidict.pyx also need __repr__ for _ViewBase.
There was a problem hiding this comment.
yes, for sure)
I must say that test_muldict.py is almost as complicated as aiohttp parsers...
Can you point me where should I put tests for cython's multidict?
There was a problem hiding this comment.
Good question. I suggest pushing along with test___repr__: https://github.com/KeepSafe/aiohttp/blob/master/tests/test_multidict.py#L269
Maybe I should refactor multidicts' test hierarchy.
popravich
force-pushed
the
multidict_repr_fixes
branch
from
9ba55a1 to
9bce9e5
Compare
|
Also fixed a typo in |
asvetlov
added a commit
that referenced
this pull request
Jun 16, 2015
Test and fix for multidicts' .items(), .keys() and .values() repr
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abc.ItemsView / KeysView / ValuesViewhas__repr__method but it expects that data is stored in._mappingattribute.First commit is failing test, second -- the fix.