Fix #4013 _resolve_host race conditions #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ojii this PR causes linter failures. Please fix those and go through the checklist above ☝️ |
This comment has been minimized.
This comment has been minimized.
psf-chronographer
bot
added
the
bot:chronographer:provided
This comment has been minimized.
This comment has been minimized.
ojii
force-pushed
the
resolve-host-race-conditions
branch
from
ccfc90a
to
e44fe14
Compare
asvetlov
approved these changes
Aug 29, 2019
|
I won't review this PR, plz handle the merge/backport this w/o me. |
|
👍 |
asvetlov
reviewed
Aug 30, 2019
Co-Authored-By: Andrew Svetlov <[email protected]>
Co-Authored-By: Andrew Svetlov <[email protected]>
Co-Authored-By: Andrew Svetlov <[email protected]>
|
Regarding @dimaqq note I can live with the current naming but if you guys want to use more meaningful names -- you are welcome. |
asvetlov
pushed a commit
that referenced
this pull request
Aug 31, 2019
(cherry picked from commit 010caab) Co-authored-by: Jonas Obrist <[email protected]>
|
Thanks! |
asvetlov
added a commit
that referenced
this pull request
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes #4013 by removing possible context switches between dictionary/cache tests and accessing those dictionaries/caches.
Are there changes in behavior for the user?
Related issue number
Fixes #4013
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.