-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable implicit switch-back to pure python mode. #3828
Conversation
The build fails loudly if aiohttp cannot be compiled with C Accellerators. Use AIOHTTP_NO_EXTENSIONS=1 to explicitly disable C Extensions complication and switch to Pure-Python mode. Note that Pure-Python mode is significantly slower than compiled one.
Should apply the same to multidict and yarl eventually. |
Is there any chance this could be backported to the 3.7.x branch? multidict and yarl already have an equivalent released :) |
btw part of the reason I would not like to build the extensions is to make a binary of the larger project reproducible. aiohttp master no longer uses distutils (since #4079) but that has not been released either :( |
I don't think so, it seems like a major change. Also, the 3.7 release stream doesn't get updates, all the new things are supposed to go into the 3.8 now. |
sure, 3.8.x would be great too, I just meant any branch that gets releases in the not-too-far future :) |
I'm not sure sure that switching this behavior in a minor release is such a good idea. |
* Disable implicit switch-back to pure python mode. The build fails loudly if aiohttp cannot be compiled with C Accellerators. Use AIOHTTP_NO_EXTENSIONS=1 to explicitly disable C Extensions complication and switch to Pure-Python mode. Note that Pure-Python mode is significantly slower than compiled one.
The build fails loudly if aiohttp cannot be compiled with C Accellerators.
Use AIOHTTP_NO_EXTENSIONS=1 to explicitly disable C Extensions complication and switch to Pure-Python mode.
Note that Pure-Python mode is significantly slower than compiled one.