Set up CI with Azure Pipelines #3827
Conversation
[skip ci]
|
Great idea. Let me know if you want any help. |
|
I'd like to get an initial working setup and iterate over in separate requests. |
|
Here's a very good curated template for Azure Pipelines: https://github.com/tox-dev/azure-pipelines-template |
|
But yes, we can merge whatever works initially and iterate on that later. |
| @@ -1,5 +1,3 @@ | |||
| """HTTP client functional tests against aiohttp.web server""" | |||
There was a problem hiding this comment.
Please keep the module docstring.
There was a problem hiding this comment.
Why? What is the point?
There was a problem hiding this comment.
When I open a python module, regardless of whether it is a test suite or not it helps me to understand what I'm about to see next, get some context and decide whether I need to read further.
There was a problem hiding this comment.
I have a different position: docstrings are for public API only.
It should be just a comment otherwise.
| @@ -1200,7 +1198,7 @@ def do_release(): | |||
| app.router.add_post('/', handler) | |||
| client = await aiohttp_client(app) | |||
|
|
|||
| with fname.open() as f: | |||
There was a problem hiding this comment.
It'd be nice to move this to a separate PR.
There was a problem hiding this comment.
The test fails on azure but is passed on appveyor
There was a problem hiding this comment.
Okay, but I still think that it'd be nice to separate this and only keep the CI config here so that it'd be more atomic.
There was a problem hiding this comment.
I cannot test it in a separate PR, this is the problem.
|
I think it may make sense to focus on GitHub workflows as they provide more resources. |
|
Like Windows and MacOS boxes? |
|
Yes |
|
"GitHub Actions is currently in limited public beta and is subject to change. We strongly recommend that you do not use this feature for high-value workflows and content during the beta period." I want to use a tool, not fight with unstable yet features. aiohttp itself provides a lot of space for experimenting. |
|
I think they forgot to update that. Basically, anybody applying for access gets it instantly now and it's going to be generally available on Nov 13. |
|
Done by separate PRs |
No description provided.