[3.5] Make sure the closing boundary is written when calling 'write' on an empty MultipartWriter (#3520) #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on an empty MultipartWriter (#3520) (cherry picked from commit 0ad5d90) Co-authored-by: Arthur Darcet <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 3.5 #3756 +/- ##
==========================================
+ Coverage 97.88% 97.94% +0.05%
==========================================
Files 44 44
Lines 8578 8576 -2
Branches 1382 1380 -2
==========================================
+ Hits 8397 8400 +3
+ Misses 74 71 -3
+ Partials 107 105 -2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 0ad5d90)
Co-authored-by: Arthur Darcet [email protected]
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.