Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do print argument optional on run_app function #3690

Merged
merged 4 commits into from
Apr 13, 2019
Merged

Do print argument optional on run_app function #3690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0617aa9
Do print argument optional on run_app function
dutradda Apr 12, 2019
391fc36
Update CONTRIBUTORS.txt
dutradda Apr 12, 2019
0976d0d
Create 3690.misc
dutradda Apr 12, 2019
7f9be1c
Fix CONTRIBUTORS.txt sorting
dutradda Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3690.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do print argument optional on run_app function
1 change: 1 addition & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ Denilson Amorim
Denis Matiychuk
Dima Veselov
Dimitar Dimitrov
Diogo Dutra da Mata
Dmitriy Safonov
Dmitry Doroshev
Dmitry Lukashin
Expand Down
4 changes: 2 additions & 2 deletions aiohttp/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ async def _run_app(app: Union[Application, Awaitable[Application]], *,
sock: Optional[socket.socket]=None,
shutdown_timeout: float=60.0,
ssl_context: Optional[SSLContext]=None,
print: Callable[..., None]=print,
print: Optional[Callable[..., None]]=print,
backlog: int=128,
access_log_class: Type[AbstractAccessLogger]=AccessLogger,
access_log_format: str=AccessLogger.LOG_FORMAT,
Expand Down Expand Up @@ -379,7 +379,7 @@ def run_app(app: Union[Application, Awaitable[Application]], *,
sock: Optional[socket.socket]=None,
shutdown_timeout: float=60.0,
ssl_context: Optional[SSLContext]=None,
print: Callable[..., None]=print,
print: Optional[Callable[..., None]]=print,
backlog: int=128,
access_log_class: Type[AbstractAccessLogger]=AccessLogger,
access_log_format: str=AccessLogger.LOG_FORMAT,
Expand Down