Fix stream .read() / .readany() / .iter_any() (#3525) #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asvetlov URGENT patch. Major bug. Please merge and backport as soon as possible. |
|
Any test? |
|
Later I will write. I consider to merge immediatelly. As 3.x is heavily broken |
|
Well, ok. Will do just after passing CI |
Codecov Report
@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
- Coverage 97.94% 97.92% -0.03%
==========================================
Files 44 44
Lines 8562 8562
Branches 1381 1381
==========================================
- Hits 8386 8384 -2
- Misses 71 72 +1
- Partials 105 106 +1
Continue to review full report at Codecov.
|
asvetlov
pushed a commit
that referenced
this pull request
Jan 11, 2019
(cherry picked from commit 5c4cb82) Co-authored-by: Коренберг Марк <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Jan 12, 2019
…3528) (cherry picked from commit 5c4cb82) Co-authored-by: Коренберг Марк <[email protected]>
socketpair
added a commit
that referenced
this pull request
Jan 21, 2019
socketpair
added a commit
that referenced
this pull request
Jan 21, 2019
asvetlov
pushed a commit
that referenced
this pull request
Jan 21, 2019
asvetlov
pushed a commit
that referenced
this pull request
Jan 21, 2019
…) (#3560) (cherry picked from commit c3f494f) Co-authored-by: Коренберг Марк <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Jan 21, 2019
…) (#3560) (#3565) (cherry picked from commit c3f494f) Co-authored-by: Коренберг Марк <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.