Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL quote in the update_path method #351

Closed
wants to merge 2 commits into from
Closed

Fix URL quote in the update_path method #351

wants to merge 2 commits into from

Conversation

TigorC
Copy link

@TigorC TigorC commented May 5, 2015

No description provided.

kxepal
kxepal reviewed May 5, 2015
View reviewed changes
aiohttp/helpers.py
@@ -225,6 +225,17 @@ def parse_remote_addr(forward):
return remote[0], str(remote[1])


def unquote_quote(segment):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unquote_quoted sounds better. otherwise it's not simply to guess what it actually does (:

@asvetlov
Copy link
Member

Maybe we need normalize_path function which will convert

ALPHA
(%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E),
underscore (%5F), or tilde (%7E)

to standard form?

As well ./ and ../ should be converted according to "Reference Resolution" chapter of rfc 3986?

@Lothiraldan Lothiraldan mentioned this pull request Jun 17, 2015
Merged
@fafhrd91 fafhrd91 closed this May 23, 2016
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TigorC @asvetlov @ludovic-gasc @kxepal @fafhrd91