Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Ignore done tasks (#3500) #3503

Merged
merged 1 commit into from
Jan 8, 2019
Merged

[3.5] Ignore done tasks (#3500) #3503

merged 1 commit into from
Jan 8, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 8, 2019

Co-authored-by: Andrew Svetlov [email protected]

* Fix #3497: Ignore done tasks when cancels pending activities on web.run_app finalization.
(cherry picked from commit 4e99e81)

Co-authored-by: Andrew Svetlov <[email protected]>
@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #3503 into 3.5 will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.5    #3503      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.02%     
==========================================
  Files          44       44              
  Lines        8563     8565       +2     
  Branches     1381     1382       +1     
==========================================
+ Hits         8386     8387       +1     
  Misses         72       72              
- Partials      105      106       +1
Impacted Files Coverage Δ
aiohttp/helpers.py 96.74% <100%> (+0.01%) ⬆️
aiohttp/web.py 99.1% <0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396ec1f...a3d18a8. Read the comment docs.

@asvetlov asvetlov merged commit 22e9723 into 3.5 Jan 8, 2019
@asvetlov asvetlov deleted the backport-4e99e81-3.5 branch January 8, 2019 09:36
@lock
Copy link

lock bot commented Jan 8, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR bug outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants